Page 1 of 1

Navigating to prev/next difference issue

Posted: Thu Apr 07, 2022 5:11 pm
by Alexo
The problem is that navigating to next/prev difference also considers resolved differences, which makes navigating to *actual* differences inconvenient.

See recording:
https://i.imgur.com/M3skUW4.mp4

Re: Navigating to prev/next difference issue

Posted: Fri Apr 08, 2022 2:34 pm
by psguru
Here's how it works now. There is a Skip checkbox on the top bar, to the right of the diff combo box. This setting is respected by the Next/Current/Previous diff navigation. So you can mark a diff as unimportant (skipped).

Now, when you resolve a diff, this checkbox becomes disabled but the diff is still included in navigation.

One potential improvement would be to (1) automatically mark Skipped for a resolved diff and (2) keep Skip always enabled, thus allowing the user to keep the resolved diff in navigation. This seems sensible but may not be straightforward to implement, considering that Skipped states can be optionally preserved ("Preserve skipped blocks" under Options | Misc).

Another option is to keep the Skip functionality as is and simply exclude resolved diffs from navigation.

Thoughts?

Re: Navigating to prev/next difference issue

Posted: Fri Apr 08, 2022 3:29 pm
by psguru
On the other hand, if we go with the second option, always skipping resolved diffs may not be what all users will like. So if we do it, there should be another option. Of course, sometimes the best option is to not change anything.

Re: Navigating to prev/next difference issue

Posted: Fri Apr 08, 2022 3:36 pm
by Alexo
psguru wrote: Fri Apr 08, 2022 2:34 pm Another option is to keep the Skip functionality as is and simply exclude resolved diffs from navigation.
A checkbox or button for enabling/disabling this behaviour, plus a default setting, should suffice.

And speaking of skipped blocks, I have a couple of comments:
1. The diff-bar colour of a selected diff is yellow regardless of its skipped status. I find it non-intuitive.
2. Is there a way to "unskip" all the skipped diffs?

Thank you.

Re: Navigating to prev/next difference issue

Posted: Fri Apr 08, 2022 4:09 pm
by psguru
A checkbox or button for enabling/disabling this behavior, plus a default setting, should suffice.
If we go ahead with this, the change will appear in version 13.0.
1. The diff-bar colour of a selected diff is yellow regardless of its skipped status. I find it non-intuitive.
Yes, selected diff color on the side diff bar is always yellow. There are other visual cues (see the top bar), and we wanted to avoid having too many colors.
2. Is there a way to "unskip" all the skipped diffs?
There is no such command.

Re: Navigating to prev/next difference issue

Posted: Fri Apr 08, 2022 7:12 pm
by Alexo
Hi psguru,
psguru wrote: Fri Apr 08, 2022 4:09 pm
A checkbox or button for enabling/disabling this behavior, plus a default setting, should suffice.
If we go ahead with this, the change will appear in version 13.0.
I must be missing something:
Capture.JPG
Capture.JPG (30.21 KiB) Viewed 4299 times
psguru wrote: Fri Apr 08, 2022 4:09 pm
2. Is there a way to "unskip" all the skipped diffs?
There is no such command.
I'd like to request it, or a simple workaround.

Thank you!

Re: Navigating to prev/next difference issue

Posted: Sat Apr 09, 2022 9:54 am
by psguru
I must be missing something:
The change, with the new option, will go to a 13.0 build, not 12.0.
I'd like to request it, or a simple workaround.
The skipped state will be reset on recomparison, if "Preserve skipped blocks" under Options | Misc is not checked.

Re: Navigating to prev/next difference issue

Posted: Sat Apr 09, 2022 9:57 pm
by Alexo
Thanks.